FEAT Breaking: Adding tags to registry classes#1485
Merged
rlundeen2 merged 2 commits intomicrosoft:mainfrom Mar 19, 2026
Merged
FEAT Breaking: Adding tags to registry classes#1485rlundeen2 merged 2 commits intomicrosoft:mainfrom
rlundeen2 merged 2 commits intomicrosoft:mainfrom
Conversation
ValbuenaVC
reviewed
Mar 17, 2026
romanlutz
approved these changes
Mar 18, 2026
hannahwestra25
approved these changes
Mar 19, 2026
Co-authored-by: Roman Lutz <romanlutz13@gmail.com> Co-authored-by: hannahwestra25 <hannahwestra@microsoft.com>
riyosha
pushed a commit
to riyosha/PyRIT
that referenced
this pull request
Mar 24, 2026
Co-authored-by: Roman Lutz <romanlutz13@gmail.com> Co-authored-by: hannahwestra25 <hannahwestra@microsoft.com>
jbolor21
pushed a commit
to jbolor21/jbolor-PyRIT
that referenced
this pull request
Mar 25, 2026
Co-authored-by: Roman Lutz <romanlutz13@gmail.com> Co-authored-by: hannahwestra25 <hannahwestra@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a
RegistryEntry[T]wrapper type and tag support for instance registries, enabling categorization and tag-based retrieval of registered components. For example, this can let us organize items in the registry by more than just name.This breaks the existing registry return type, but that's really new so I didn't deprecate it